Make sure create_repo respect organization privacy settings #2679
+50
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see slack thread (private)
Enterprise Hub allows organizations to force all repositories to be private. Since
create_repoassumes that a repo is public whenprivate=Trueis not explicitly passed, an error is thrown by the serverThis is because
private: Falseis passed by default (since #1001 😕). This PR updates this by makingNonethe default value forprivateand send the value to the server only when explicitly set by the user. This should make the life of Enterprise Hub users much easier (today they need to explicitly passprivate=Truein their calls).Note: tests are currently failing (need an update in staging org settings).
Note 2: we'll have to update many (most?)
.push_to_hubsignature in the HF ecosystem to also passNonewhenever appropriate. I'll open PRs once that's merged.TIL: better listen to the boss #1001 (comment)